braintwo at gmail.com
Mon Nov 16 20:23:13 UTC 2020
Thanks Marco! I'm really happy this is merged.
I'll consider how run_p can verify the output; as well as checking that
this is done consistently in other tests
Was there any specific things you thought could be improved? Happy to look
at those too.
On Mon, Nov 16, 2020 at 11:36 AM Marco Bodrato <bodrato at mail.dm.unipi.it>
> Il 2020-10-16 09:51 Seth Troisi ha scritto:
> > I included a patch with the rename but not including Marco's tdiv
> I pushed most of the changes you proposed.
> I only removed some portion of the proposed tests/mpz/t-nextprime.c.
> You are right, also the return value of the new function should be
> tested, but I think that we should find a way to check both the result
> and the return value of single runs of the function. E.g. test_largegap
> can check that mpz_prevprime always returns 1 or 2, and run_p may take
> another parameter so that we can check (depending on the range) if 2 is
> returned as expected, or 1 is enough...
> Let's see if we can improve it even more :-)
More information about the gmp-devel