Torbjörn Granlund tg at gmplib.org
Wed Jan 22 20:47:31 UTC 2020

nisse at lysator.liu.se (Niels Möller) writes:

  I'll try to clarify, then.

  If we have a working piece of code under #if FOO_METHOD == 4 that's
  currently never used, I think it is fine to keep it around, in case it
  turns out to be useful on some future processor.
  But if we have multiple copies of that unused method, that starts to
  bothers me. If we decide to duplicate all the div1 and div2 methods in
  both hgcd2.c and hgcd2_jacobi.c, then maybe we should delete the
  HGCD2_DIV1_METHOD 2 and/or 4 versions first, to reduce the amount of
  code duplication?

Would jacobi div1/div2 be identical to the ones for gcd?  Then, I
believe we might want to put them into an include file.

There is one reason why I am tempted to keep unused code around, code
which we at some point thought would be a good idea.  That reason is
that we don't five or ten years from now make the same futile attempt.

(Code which would add size to the compile library is a different matter,
of course.)

Please encrypt, key id 0xC8601622

More information about the gmp-devel mailing list