Aggregated Patch

"Jürgen Bullinger" juergen.bullinger at gmx.net
Sat Feb 11 20:11:53 CET 2006


Hi Torbjorn,

thank you for your answer.
If you like, I could try to maintain such an aggregated patch.
Do you think there are a lot of changes over time?
I saw that the last update on the tid-bits-site was about October 2005, so I
thought there are not so many.

Unfortunately I still have some questions.

I could compile gmp with all the patches installed without any obvious
errors, but when I try to do a make check it complains about missing
symbols.
All the missing symbols seem to be related to the functions in qstack.c.
This file seems to be introduced by Niels Möller's gcdext-Patch. I guess
this file just hasn't been included in the build instructions yet (but how
could it be included?). Could you please tell me where I would have to
include this file in the build instructions?

Another thing I am unsure about is the symbol MUL_TOOM3_THRESHOLD_LIMIT
which is needed by Paul Zimmermann's optimized TOOM3-Code. I defined it in
gmp-impl.h as follows:

#ifndef MUL_TOOM3_THRESHOLD_LIMIT
#define MUL_TOOM3_THRESHOLD_LIMIT  MUL_TOOM3_THRESHOLD
#endif

Does this definition make sense, or should the value be different from the
MUL_TOOM3_THRESHOLD?

And the third thing is, I recognized there are two conflicting definitions
of mpn_sqr_n after installing all the patches. One of these definitions is
in mpn/generic/mul.c and one is in mpn/generic/mul_n.c. I guess the one in
mpn/generic/mul_n.c (in the version of Paul Zimmermann's toom3-patch) is the
new one.
So I guess it should be enough to rename the old definition in mul.c in the
installation process, so that it is not referenced anymore. Is this right?

Thank you in advance

Juergen

-- 
DSL-Aktion wegen großer Nachfrage bis 28.2.2006 verlängert:
GMX DSL-Flatrate 1 Jahr kostenlos* http://www.gmx.net/de/go/dsl


More information about the gmp-discuss mailing list