mul_fft, cleaning up some details of the code
Torbjörn Granlund
tg at gmplib.org
Sun Mar 6 12:16:58 CET 2022
Marco Bodrato <bodrato at mail.dm.unipi.it> writes:
This is not really needed to solve a bug.
The comment before the mpn_mul_fft_decompose function says "We must
have nl <= 2*K*l", this means that we should never have ((dif = nl -
Kl) > Kl), and the code in that branch should never be used.
I noticed that at some point too, and have had a patch lying around for
quite a while:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mul_fft.c.diff
Type: text/x-patch
Size: 1930 bytes
Desc: not available
URL: <https://gmplib.org/list-archives/gmp-devel/attachments/20220306/43a08639/attachment.bin>
-------------- next part --------------
(Not sure about the separate FIXME change therein; it looks strange to
me now.)
Feel free to clean this up.
--
Torbj?rn
Please encrypt, key id 0xC8601622
More information about the gmp-devel
mailing list