fast inversion

bodrato at mail.dm.unipi.it bodrato at mail.dm.unipi.it
Wed May 20 03:57:46 UTC 2015


Ciao,

Il Mar, 19 Maggio 2015 10:02 am, Niels Möller ha scritto:
> The declaration of mpn_com looks a bit fishy. It's conditionally declared
> in gmp-h.in, inside an
>
>   #if __GMP_INLINE_PROTOTYPES || defined (__GMP_FORCE_mpn_com)
>
> But the inline definition is in gmp-impl.h, not gmp-h.in, so not visible
> to user code including only gmp.h.

This is not just fishy, it's wrong. I removed the #if.

> And the inline definition is conditional on !HAVE_NATIVE_mpn_com,

But it is not an inline function, it's a macro redefining mpn_com, it will
not conflict with the prototype __gmpn_com. (I hope ;-)

Best regards,
m

-- 
http://bodrato.it/



More information about the gmp-devel mailing list