fast inversion

Niels Möller nisse at lysator.liu.se
Tue May 19 08:02:16 UTC 2015


tg at gmplib.org (Torbjörn Granlund) writes:

> There are new build failures which seem related to this change.

The declaration of mpn_com looks a bit fishy. It's conditionally declared
in gmp-h.in, inside an

  #if __GMP_INLINE_PROTOTYPES || defined (__GMP_FORCE_mpn_com)

But the inline definition is in gmp-impl.h, not gmp-h.in, so not visible
to user code including only gmp.h. And the inline definition is
conditional on !HAVE_NATIVE_mpn_com, so that makes it non-trivial to
simply move it to gmp-h.in. I'm a bit lost with all the preprocessor
conditionals.

And then the c++ compiler on aix seems particularly picky about missing
declarations.

I'd suggest to drop the inlining of mpn_com, and just use the
implementation in generic/com.c for platforms that lack a native
implementation.

Regards,
/Niels


-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.


More information about the gmp-devel mailing list