[PATCH] Improve System z support and add some tuning

Andreas Krebbel krebbel at linux.vnet.ibm.com
Tue Sep 27 15:54:58 CEST 2011


On 09/27/2011 12:13 PM, Torbjorn Granlund wrote:
> "Andreas Krebbel" <krebbel at linux.vnet.ibm.com> writes:
> 
>   the attached patch improves support for s390 and s390x and adds tuning
>   for 3 System z machine models.
>   
>   The testsuite is clean for the 3 tuned CPU models: z900 z10 z196 with
>   the configurations: s390, s390x ABI=32, and s390x ABI=64.
>   
> Great!
> 
> I am slightly worried about the continued testing of the s390 support.
> For systems to which the main GMP developers have no access, I try to
> setup qemu-based testing.  Since you work for IBM, perhaps you can put
> me in touch with somebody who can help with that?

I can help with testing. I'm doing GCC, GDB, Binutils and Glibc tests on a daily base and
libgmp can easily be added I think.

> This is a significant contribution, meaning that we need paperwork for
> it: We need assignments from you, and copyright disclaimer from your
> employer.

Mmmh. I hoped that this qualifies as a bugfix. The gmp-mparam.h files are completely
generated by the tune tool. So I don't have a copyright here anyway. longlong.h is part of
the GCC project and I have the paperwork in place for that.

So the patch can be reduced to the configury and tune/time.c changes. Both are obvious
changes to me. The time.c stuff only copies one else branch to another place without
adding code.

> I've seen your name around GNU for a long time, so perhaps you have
> relevant paperwork already in place?

I've a copyright assignment to the FSF in place which covers GCC, GDB, Glibc, and Binutils
work. Extending this will be difficult and will take months at least.

Bye,

-Andreas-


More information about the gmp-devel mailing list