missing do ... while (0) in longlong.h

Marc Glisse marc.glisse at inria.fr
Mon Aug 22 21:21:13 UTC 2016


On Thu, 4 Aug 2016, Vincent Lefevre wrote:

> The longlong.h file from GMP 6.1.1 contains:
>
> #if !defined (umul_ppmm) && defined (__umulsidi3)
> #define umul_ppmm(ph, pl, m0, m1) \
>  {                                                                     \
>    UDWtype __ll = __umulsidi3 (m0, m1);                                \
>    ph = (UWtype) (__ll >> W_TYPE_SIZE);                                \
>    pl = (UWtype) __ll;                                                 \
>  }
> #endif
>
> I suppose that "do ... while (0)" should be added like in the other
> umul_ppmm definitions.
>
> This doesn't seem to affect the current GMP code, but it might in
> the future. Who knows...

Done. I don't know what platforms use this code, I'll check the webpage 
with test results tomorrow.

-- 
Marc Glisse


More information about the gmp-bugs mailing list