missing do ... while (0) in longlong.h

Vincent Lefevre vincent at vinc17.net
Thu Aug 4 15:16:14 UTC 2016


The longlong.h file from GMP 6.1.1 contains:

#if !defined (umul_ppmm) && defined (__umulsidi3)
#define umul_ppmm(ph, pl, m0, m1) \
  {                                                                     \
    UDWtype __ll = __umulsidi3 (m0, m1);                                \
    ph = (UWtype) (__ll >> W_TYPE_SIZE);                                \
    pl = (UWtype) __ll;                                                 \
  }
#endif

I suppose that "do ... while (0)" should be added like in the other
umul_ppmm definitions.

This doesn't seem to affect the current GMP code, but it might in
the future. Who knows...

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)


More information about the gmp-bugs mailing list