remove extra division in mpq/aors.c

Torbjorn Granlund tg at gmplib.org
Sun Feb 20 14:59:09 CET 2011


Marc Glisse <marc.glisse at inria.fr> writes:

  the file doc/tasks.html mentions an extra division in
  mpq/aors.c. Would something like the attached do?
  
I find it very, very difficult to understand unidiffs.  Please use
context diffs for GMP patches.

  As a bonus, one of the multiplications is not in-place any more. We
  can do the same for the other one as well if we want (file p2).

Good!  I suppose we should at some point perform bdiv-type
precomputations on the 'gcd' value.

For making hg generate context diffs (hg cdiff), put this in your
~/.hgrc:

[extensions]
hgext.extdiff=

[extdiff]
cmd.cdiff = diff
opts.cdiff = -Nrc2

-- 
Torbjörn


More information about the gmp-discuss mailing list