[PATCH] mpn/generic/perfsqr: Improve alternate (currently disabled) test.

[marco.bodrato at tutanota.com]

Ciao,

16 feb 2026, 14:17 da sparks05 at proton.me:

> I think GCC goes too far (it complains about "a + b & c"), but I tried
>
It's a competition between GCC and clang, which one gives more useless warnings :-)

> Too many parens obscure rather than clarifying.  For me, at
> least, (three (levels (of nesting))) is the ordinary limit and
> (four (makes (me look) for (another (way to write) the) expression)).
>
I may agree, or not, but the problem now, for me, is elsewhere.

Please consider the time that readers have to spend to read your patches.

For example, consider the following lines from one of your proposed patches:

diff --git a/tune/tuneup.c b/tune/tuneup.c
index ed76f2cd9..8d822efc6 100644
--- a/tune/tuneup.c
+++ b/tune/tuneup.c
@@ -726,11 +726,10 @@ one_method (int n, speed_function_t *functions,
const struct param_t *param)
{
double *t;
-  int i;
-  int method;
-  int method_runner_up;
+  int i, method, method_runner_up;

TMP_DECL;

What's the need for this change? I spent time reading it, rereading it to check if there is some name change, read it for a third time to be sure that... there was no need at all.

So, may I ask you not to mix cosmetic changes with algorithmic ones?

Ĝis,
mb