[PATCH 0/3] aarch64: enable PAC and BTI

[Niels Möller]

Bill Roberts <bill.roberts at arm.com> writes:

> See Commit Message for More Details
>
> - V7:
>   - Drop GMP_GET_MACRO_VALUE
>   - Drop GMP_CHECK_PROG
>   - configure.ac already uses sed and grep, hardcoded, so add checks for them
>     and use the variables over the direct command
>   - Bolster documentation with links to the Arm ARM, ABI and Blog documentations
>     - Make some clarifications in the commit message as well
>   - Add NONLEAF_PROLOGUE instead of calling PROLOGUE(xxx, true)
>     - naming convention follows MULFUNC_PROLOGUE naming convention
>     - Update the pattern matching for determining if generic C or asm should be used
>     - Requires EGREP for automatic configuration of assembly routines over generic
>       C implementations
>   - Add License to t-arm64_elf_check.sh
>   - Detect sed and grep using autoconf and use the proper SED and GREP variables
>     respectively to invoke them vs hardcoding it
>   - Drop erroneous Makefile.am formatting change

Hi, I think the interesting parts are getting into good shape, but I am
distracted by questionable peripheral changes.

I also have a question on copyright. I take it you are doing this work
on behalf of your employer? Do you know if ARM Limited (is that the
proper company name?) has a copyright assignment agreement in place with
the FSF, that covers GMP, of if we need to do some paperwork?

Concrete suggestions:

Please drop the sed, grep and egrep configure checks, I think the job
can be done with portable mainstream features of sed and grep (and in
addition, your use egrep looks suspicious, as I read it, is '(' used
both for grouping and as a literal character to match). See
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/autoconf.html#Limitations-of-Usual-Tools
for some advice on which features of sed and grep to avoid.

Please drop configure check for readelf, just let the test script exit
with a log message and exit code 77 if readelf is unavalable.

I would prefer to also drop the dependency on bash, are bash features
really essential for this test? From a quick look, I see no use of fancy
things like bash arrays. (I do see a mix of [ ... ] and bash-specific [[
... ]], which is a bit inconsistent).

Regards,
/Niels

-- 
Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
Internet email is subject to wholesale government surveillance.