[PATCH 3/3] Rewrite the MIPS legecy code as MIPS r6 style

Torbjörn Granlund tg at gmplib.org
Thu May 23 21:01:49 UTC 2019

YunQiang Su <syq at debian.org> writes:

  The r6 style code is much shorter and with the same performance,
  to make it easy to maintain, we rebase the code with new style:

I read unidiffs really poorly, in particular for asm code.  But to me,
it seems like you undo the software pipelining of the current MIPS code,
replacing it with plain ("naive") asm code.  I am not sure that is a
good idea.

On which MIPS CPUs did you test and benchmark the code?  Did you not see
performance regressions?

Granted, the MIPS asm code in GMP is largely obsolete as it was
optimised for defunct MIPS CPUs.  But having said that, I would like to
avoid performance regressions for new as well as old implementations.
And removing software pipelining almost always hurt performance.

Please encrypt, key id 0xC8601622

More information about the gmp-devel mailing list