[PATCH] Add support for building for windows on aarch64

Niels Möller nisse at lysator.liu.se
Wed Apr 18 05:07:03 UTC 2018


Martin Storsjö <martin at martin.st> writes:

> The attached patch fixes building GMP for windows on aarch64 using the
> llvm-mingw toolchain (clang with a mingw sdk, built on top of llvm
> tools).

Looks good to me, just a few questions.

What machines run windows on aarch64, windows phones or also more
general computers? Are you cross compiling only, or can you compile
natively on these machines?

I imagine the change isn't really compiler specific, you'd need the same
to cross compile using gcc (if gcc and mingw support this target?).

> The main issue is, just like on x86_64, "long" still is 32 bit, while
> the current configure check on arm/aarch64 checks that sizeof(long) ==
> 8 in order to use a 64 bit ABI. (On x86_64, no such check is
> executed.) The patch changes the check to test sizeof(void*) instead.

I'm a bit curious as to why it's different on x86_64; there we only have
a test of $host matching *-*-mingw or *-*-cygwin, and set
limb64=longlong in that case.

On arm, do we rely on the compiler's default abi, so we need the
any_*_testlist to detect that? I see no use of -m32/-m64 in the arm
section, but I may be missing something.

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject to wholesale government surveillance.


More information about the gmp-devel mailing list