mpq_cmp_z

Marco Bodrato bodrato at mail.dm.unipi.it
Thu Sep 3 20:00:47 UTC 2015


Ciao,

Il Gio, 3 Settembre 2015 11:14 am, Torbjörn Granlund ha scritto:
> "Marco Bodrato" <bodrato at mail.dm.unipi.it> writes:
>   PS: I'm not very happy for the testing code... too general to finely
>   explore the corner cases for the size-based branches...

> All branches except the SALLOC/BALLOC ones hiding under TMP_* seem to be
> covered: https://gmplib.org/devel/lcov/shell/gmp/mpq/cmp.c.gcov.html

I know, but when you write conditions like (a>b) you don't just have to
test the two cases (a>b) and (a<b), you may need to be sure that the
corner-cases (eg, a==b) are tested.

With the last push, I'm satisfied.

Regards,
m

-- 
http://bodrato.it/



More information about the gmp-devel mailing list