TODO for 5.2 v3

[Niels Möller]

bodrato at mail.dm.unipi.it writes:

> Ciao,
>
> Il Mar, 7 Gennaio 2014 4:58 pm, Niels Möller ha scritto:
>> Here's a first patch adding a couple of other functions. Benchmarking
>> and testing is missing (except that the sec_minvert tests still pass).
>
> Interesting...

Another thing I was about to ask, but forgot, is use of volatile.

I added it to the mpn_cnd_swap and mpn_sec_eq_ui prototypes, in an
attempt to tell the compiler to not be too clever. But I'm not entirely
sure where it is useful.

>> diff -r 84343784aa3d mpn/x86_64/cnd_neg.asm
>> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
>> +++ b/mpn/x86_64/cnd_neg.asm	Tue Jan 07 15:13:37 2014 +0100
>
> What about _itch functions when the .asm source is used?

They're supposed to exist, and return zero. E.g.,

+PROLOGUE(mpn_cnd_neg_itch)
+	xor	R32(%rax), R32(%rax)
+	ret
+EPILOGUE()

>> +C scratch parameter is ignored
>
> _itch should return 0...
>
> And some obvious patch like the following would take advantage of this.

Nice, but won't make any difference until we have mpn_sec_add_1
assembly, right?

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.