[PATCH 0/3] Resubmit of Sparc T3/T4 patches.

David Miller davem at davemloft.net
Tue Mar 5 22:38:56 CET 2013


From: David Miller <davem at davemloft.net>
Date: Tue, 05 Mar 2013 16:36:12 -0500 (EST)

> From: Torbjorn Granlund <tg at gmplib.org>
> Date: Tue, 05 Mar 2013 22:33:30 +0100
> 
>> David Miller <davem at davemloft.net> writes:
>> 
>>   The versions I posted passed all of the tests.
>>   
>> What does "all the tests" mean?
>> 
>> I insists that you run tests/devel/try.  Please send me the output of
>> the command I asked you to run.
>> 
>> Running GMP's test suite is *not* adequate for testing new assembly
>> code.
> 
> Fair enough.  Give me a moment.

The new code is used:

davem at patience:~/src/GIT/GMP/build-sparc64$ ls -l mpn/*.asm | grep t3
lrwxrwxrwx 1 davem davem 47 Mar  4 21:15 mpn/addmul_1.asm -> ../../gmp/mpn/sparc64/ultrasparct3/addmul_1.asm
lrwxrwxrwx 1 davem davem 44 Mar  4 21:15 mpn/add_n.asm -> ../../gmp/mpn/sparc64/ultrasparct3/add_n.asm
lrwxrwxrwx 1 davem davem 44 Mar  4 21:15 mpn/mul_1.asm -> ../../gmp/mpn/sparc64/ultrasparct3/mul_1.asm
lrwxrwxrwx 1 davem davem 47 Mar  4 21:15 mpn/submul_1.asm -> ../../gmp/mpn/sparc64/ultrasparct3/submul_1.asm
lrwxrwxrwx 1 davem davem 44 Mar  4 21:15 mpn/sub_n.asm -> ../../gmp/mpn/sparc64/ultrasparct3/sub_n.asm
davem at patience:~/src/GIT/GMP/build-sparc64$ 

The 'try' test passes:

davem at patience:~/src/GIT/GMP/build-sparc64/tests/devel$ ./try -s1-10 mpn_add_n mpn_sub_n mpn_mul_1 mpn_addmul_1 mpn_submul_1
pagesize is 0x2000 bytes
s[0] 0xfffff80100048000 to 0xfffff8010004a000 (0x2000 bytes)
s[1] 0xfffff8010008c000 to 0xfffff8010008e000 (0x2000 bytes)
s[2] 0xfffff801000d0000 to 0xfffff801000d2000 (0x2000 bytes)
s[3] 0xfffff8010052e000 to 0xfffff80100530000 (0x2000 bytes)
s[4] 0xfffff80100572000 to 0xfffff80100574000 (0x2000 bytes)
ref d[0] 0xfffff801005b6000 to 0xfffff801005b8000 (0x2000 bytes)
ref d[1] 0xfffff801005fa000 to 0xfffff801005fc000 (0x2000 bytes)
fun d[0] 0xfffff8010063e000 to 0xfffff80100640000 (0x2000 bytes)
fun d[1] 0xfffff80100682000 to 0xfffff80100684000 (0x2000 bytes)
mpn_add_n 409600
\ 367457
mpn_sub_n 409600
\ 378090
mpn_mul_1 358400
\ 341323
mpn_addmul_1 358400
- 268788
mpn_submul_1 358400
- 291370
davem at patience:~/src/GIT/GMP/build-sparc64/tests/devel$ echo $?
0
davem at patience:~/src/GIT/GMP/build-sparc64/tests/devel$ 


More information about the gmp-devel mailing list