[PATCH] Improve and consolidate sparc PIC assembler.

[David Miller]

From: David Miller <davem at davemloft.net>
Date: Sun, 14 Apr 2013 21:35:27 -0400 (EDT)

> I'd like to investigate what went on here in more detail, and I think
> I can do it if you build the test images in the attached tarball for
> me.

In talking to my Oracle contact and doing some data mining, I'm
pretty sure we were hitting bug 6274959 in the assembler.  He
says lots of people hit that as well as the TLS symbol thing
we hit too.

Take a look at:

https://getupdates.oracle.com/readme/README.118683-08

and down in the "from 118683-02" section it says:

6274959 'fbe' assembler generates wrong code related to %gdop_lox10 in shared library

118683-02 is a patch which was released more than 6 years ago.

Even GCC requires that at least 118683-03 be installed on Solaris 10,
and that Solaris patch was released more than 4 years ago.

I think it would be rather reasonable to require that 6 year old bug
fixes in the assembler be installed, but that's of course up for
discussion.

Now, once I have the tarball of images created on a machine that has
the buggy assembler with the -D__PIC__ thing added to the gcc command
line, I could look and see how feasible it would be to write detection
code for this bug in the GMP acinclude.m4 macros.

I had my Oracle contact build my test tarball on one of his Solaris 10
systems and all the gotdata relocs and symbol types look to be
correct.

I'm going to install Solaris 10 on my SunBlade2500 but it's not going
to help me in testing this particular problem if we insist on
supporting older Solaris 10 assemblers, because the oldest Solaris 10
install image I was able to obtain has 118683-10 already integrated,
so it won't have any of the assembler bugs we ran into.