[PATCH] Improve and consolidate sparc PIC assembler.

Torbjorn Granlund tg at gmplib.org
Wed Apr 10 14:35:13 CEST 2013


Please use LEA* instead of LOAD_SYMBOL*, since that's what we use
elsewhere.  (OK, LEA might be a misnomer, but a well-established one in
and outside of GMP.)

I assume your broad testing covers every modified file.  Do you have an
idea of whether that is true.

Whn testing shared libs, I have found that libtool sometimes prefers an
instaled version to the newly compiled version.  That happens more often
with 32-bit libs on 64-bit systems, since libtool doesn't set
LD_32_LIBRARY_PATH.  Please make sure the shared builds' libraries have
actually been tested.

That patch looks good to me, apart from the LEA issue.

Once you have addressed that, I would like to commit this to the main
repo.

Thanks!

-- 
Torbjörn


More information about the gmp-devel mailing list