mpz_combit

[Niels Möller]

[ A late reply, regarding combit and friends ]

Torbjorn Granlund <tg at gmplib.org> writes:

> I thought we had discussed this.  The change is fine, optimising the
> common case is a great thing in general.

Checked in a whiel ago.

> Did you consider analogous changes for the sibling functions, clrbit and
> setbit?

No, but I expect them to be a bit different. With negative numbers, I
think it's a common case that more than one bit of the absolute value is
affected.

> Do you want the suggested incompatible change listed on the incompatible
> web page?

Yes. (The suggestion was to let combit return the old (or new, if that
makes more sense) value of the bit, and possibly also have setbit and
clrbit return the old value).

Maybe it would be good to keep that file in the repo?

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.