[PATCH] support for mingw-w64

Ozkan Sezer sezeroz at gmail.com
Fri Sep 11 11:38:57 CEST 2009


On Fri, Sep 11, 2009 at 12:26 PM, Torbjorn Granlund <tg at gmplib.org> wrote:
> Thanks for the GMP patch!
>
> Comments:
>
> * We unfortunately cannot use intptr_t unconditionally, since it is not
>  available everywhere we want GMP to work; it is a C99 feature.
>
>  I wonder if size_t could be used instead?  While perhaps not elegant,
>  it should work.  Does anybody see any problem?
>

Hmm, ssize_t would be a better choice, IMHO, for matched
signedness, but ..

>  (Alternatively, we could define our own little type, gmp_intptr_t
>  which we set up in gmp-impl.h.  There are some precedents in that
>  file.)
>

..  this would surely be a much better solution.

> * Why is it necessarly to pass -std=c99 to gcc?
>
>  Passing this flag to gcc might be a good idea for all configurations,
>  but then it should better be done using a global feature test, perhaps
>  via our _opt flags mechanism.  Setting a globally avaiblable flags for
>  one platform seems wrong.

Without c99 mode, gcc, rightfully, emits _a lot_ of warnings like:
fib_table.c:12:1: warning: use of C99 long long integer constant
.. which is because of long long.
If you want to make it global for all targets, I have no problems
with that at all.

>
> Did you write this patch yourself?  It is large enough to be covered by

Updated an old patch

> copyright law, meaning that the GNU project needs paperwork from its
> authors.  This is a few minutes of work, but we need to protect the
> legal status of GMP for the benefit of its users.
>

I already did copyright paperwork for gcc and binutils
with fsf.  Is it necessary doing it again for gmp, too?

> --
> Torbjörn
>

--
Ozkan


More information about the gmp-devel mailing list