[Gmp-commit] /home/hgfiles/gmp: 3 new changesets

[mercurial at gmplib.org]

details:   /home/hgfiles/gmp/rev/23588ba8cddb
changeset: 13023:23588ba8cddb
user:      Niels M?ller <nisse at lysator.liu.se>
date:      Thu Dec 10 16:20:28 2009 +0100
description:
Deleted unused variable in tune_set_str.

details:   /home/hgfiles/gmp/rev/4ad8ae0b56db
changeset: 13024:4ad8ae0b56db
user:      Niels M?ller <nisse at lysator.liu.se>
date:      Thu Dec 10 16:23:12 2009 +0100
description:
Added FIXME comment.

details:   /home/hgfiles/gmp/rev/11b4d88d0e5b
changeset: 13025:11b4d88d0e5b
user:      Niels M?ller <nisse at lysator.liu.se>
date:      Thu Dec 10 16:23:55 2009 +0100
description:
Comment scratch_out being unused.

diffstat:

 mpn/generic/toom33_mul.c |  7 +++++++
 mpn/generic/toom42_mul.c |  2 +-
 tune/tuneup.c            |  2 --
 3 files changed, 8 insertions(+), 3 deletions(-)

diffs (41 lines):

diff -r 331dcec2adce -r 11b4d88d0e5b mpn/generic/toom33_mul.c
--- a/mpn/generic/toom33_mul.c	Thu Dec 10 14:59:23 2009 +0100
+++ b/mpn/generic/toom33_mul.c	Thu Dec 10 16:23:55 2009 +0100
@@ -54,6 +54,13 @@
   (MUL_TOOM44_THRESHOLD >= 3 * MUL_TOOM33_THRESHOLD)
 #endif
 
+/* FIXME: TOOM33_MUL_N_REC is not quite right for a balanced
+   multiplication at the infinity point. We may have
+   MAYBE_mul_basecase == 0, and still get s just below
+   MUL_TOOM22_THRESHOLD. If MUL_TOOM33_THRESHOLD == 7, we can even get
+   s == 1 and mpn_toom22_mul will crash.
+*/
+
 #define TOOM33_MUL_N_REC(p, a, b, n, ws)				\
   do {									\
     if (MAYBE_mul_basecase						\
diff -r 331dcec2adce -r 11b4d88d0e5b mpn/generic/toom42_mul.c
--- a/mpn/generic/toom42_mul.c	Thu Dec 10 14:59:23 2009 +0100
+++ b/mpn/generic/toom42_mul.c	Thu Dec 10 16:23:55 2009 +0100
@@ -175,7 +175,7 @@
 #define vinf  (pp + 4 * n)			/* s+t */
 #define vm1   scratch				/* 2n+1 */
 #define v2    (scratch + 2 * n + 1)		/* 2n+2 */
-#define scratch_out	scratch + 4 * n + 4
+#define scratch_out	scratch + 4 * n + 4	/* Currently unused. */
 
   /* vm1, 2n+1 limbs */
   TOOM42_MUL_N_REC (vm1, asm1, bsm1, n, scratch_out);
diff -r 331dcec2adce -r 11b4d88d0e5b tune/tuneup.c
--- a/tune/tuneup.c	Thu Dec 10 14:59:23 2009 +0100
+++ b/tune/tuneup.c	Thu Dec 10 16:23:55 2009 +0100
@@ -1753,8 +1753,6 @@
 void
 tune_set_str (void)
 {
-  static struct param_t  param;
-
   s.r = 10;  /* decimal */
   {
     static struct param_t  param;