unused macro MPN_PTR_SWAP in mini-gmp.c

Niels Möller nisse at lysator.liu.se
Sat Mar 19 12:44:29 CET 2022

Paul Eggert <eggert at cs.ucla.edu> writes:

> In libgmp 6.2.1, mini-gmp.c defines a macro without using it, causing
> the command "gcc -Wunused-macros -Werror" to fail with the following
> diagnostic:

I haven't used -Wunused-macros before, I take it it warns only about
macros defined in .c files? Since it's perfectly normal that macros
defined in .h files are unused in some of the compilation units
including the .h file?

mini-gmp.c is a bit special, in that one more-or-less recommended
usecase is to #include this file into some other compilation unit. E.g.,
like in https://gmplib.org/repo/gmp/file/tip/bootstrap.c#l33.

But probably still shouln't define macros not used within mini-gmp.c;
any additional utility macros should probably go in mini-gmp.h, and be
compatible with public macros from gmp.h.


Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
Internet email is subject to wholesale government surveillance.

More information about the gmp-bugs mailing list