unused macro MPN_PTR_SWAP in mini-gmp.c

Marco Bodrato bodrato at mail.dm.unipi.it
Thu Mar 17 19:32:10 CET 2022


Ciao Paul,

Il 2022-03-09 02:56 Paul Eggert ha scritto:
> In libgmp 6.2.1, mini-gmp.c defines a macro without using it, causing

Thanks for spotting this!

> Proposed patch attached.

There is also a different possible way to heal the problem: using it :-D

diff -r a44f487c8d20 mini-gmp/mini-gmp.c
--- a/mini-gmp/mini-gmp.c       Fri Mar 11 21:13:20 2022 +0100
+++ b/mini-gmp/mini-gmp.c       Thu Mar 17 19:15:51 2022 +0100
@@ -1938,8 +1938,7 @@
  mpz_swap (mpz_t u, mpz_t v)
  {
    MP_SIZE_T_SWAP (u->_mp_size, v->_mp_size);
-  MP_SIZE_T_SWAP (u->_mp_alloc, v->_mp_alloc);
-  MP_PTR_SWAP (u->_mp_d, v->_mp_d);
+  MPN_PTR_SWAP (u->_mp_d, u->_mp_alloc, v->_mp_d, v->_mp_alloc);
  }



Ĝis,
m


More information about the gmp-bugs mailing list