with strict C99 the tests/mpz/convert.c needs #include <strings.h>

Torbjörn Granlund tg at gmplib.org
Mon Nov 9 09:14:37 UTC 2020


Vincent Lefevre <vincent at vinc17.net> writes:

  In the context of the call, the values will always be nonnegative
  so that this is OK, but there is a risk that some future developer
  might reuse this function in another context, where it would be
  incorrect on platforms with signed char (in particular, there is
  no warning in the comment).

Perhaps we could rename this function
note_that_this_funtion_is_called_str_casecmp_and_not_strcasecmp, to
avoid such looming disaster?  Or, to be more polite, perhaps
please_note_that_this_funtion_is_called_str_casecmp_and_not_strcasecmp?

-- 
Torbjörn
Please encrypt, key id 0xC8601622


More information about the gmp-bugs mailing list