with strict C99 the tests/mpz/convert.c needs #include <strings.h>
Vincent Lefevre
vincent at vinc17.net
Sun Nov 8 23:20:57 UTC 2020
On 2020-11-07 18:45:52 -0500, Dennis Clarke wrote:
> However the tests blow up due to :
>
> convert.c:143:11: error: implicit declaration of function 'strcasecmp'
> is invalid in C99
>
> So that is easy to fix.
>
> ijiraq# diff -u ./tests/mpz/convert.c.orig ./tests/mpz/convert.c
> --- ./tests/mpz/convert.c.orig 2020-01-17 13:44:49.000000000 +0000
> +++ ./tests/mpz/convert.c 2020-11-07 22:51:36.823215000 +0000
> @@ -21,6 +21,7 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h> /* for strlen */
> +#include <strings.h> /* for strcasecmp */
>
> #include "gmp-impl.h"
> #include "tests.h"
> ijiraq#
strcasecmp is not part of C99. It should be better to convert both
strings to uppercase (with toupper) or lowercase (with tolower),
then do a usual comparison.
--
Vincent Lefèvre <vincent at vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
More information about the gmp-bugs
mailing list