generic/dive_1.c line 121
Torbjörn Granlund
tg at gmplib.org
Tue Nov 1 16:48:04 UTC 2016
Peter Barfuss <pbarfuss at csclub.uwaterloo.ca> writes:
Looking at generic/dive_1.c, this line stuck out as, uh, what on earth:
https://gmplib.org/repo/gmp-6.1/file/tip/mpn/generic/dive_1.c#l121
Based on the contents of this patchset:
https://gmplib.org/repo/gmp-6.1/rev/f00b33194300
it indeed looks very superfluous, at best.
It is not only superfluous, it is also redundant, needless and
unneccessary.
Also nearest I can tell
there are no tests for mpn_divexact or mpn_divexact_1???
Not unit-tested by 'make check' (something they share with dozen of
other low-level functions). But as evidenced by our coverage analysis
they are indirectly tested:
https://gmplib.org/devel/lcov/
--
Torbjörn
Please encrypt, key id 0xC8601622
More information about the gmp-bugs
mailing list