INT_MAX definition in gmp-impl.h conflicts with limits.h

Vincent Lefevre vincent at vinc17.net
Wed Nov 23 15:23:05 CET 2011


On 2011-11-23 14:48:32 +0100, Torbjorn Granlund wrote:
> Marc Glisse <marc.glisse at inria.fr> writes:
> 
>   For now we could work around the problem by including tests.h before
>   gmp-impl.h, and postpone thinking about this until that breaks
>   too. But I wanted to check if you had a better idea.
> 
> OK.
> 
> I support ugly hacks in the GMP test suite, while we of course want to
> keep the GMP lib code as clean as possible...

Are you sure that this works with every other platforms, configure
options and so on?

I'm wondering... tests/tests.h has:

#if HAVE_CALLING_CONVENTIONS

where HAVE_CALLING_CONVENTIONS can be defined in config.h, which is
included from gmp-impl.h. So, I would say that tests/tests.h depends
on gmp-impl.h, so that including tests.h before gmp-impl.h could
yield an incorrect build of the tests.

-- 
Vincent Lefèvre <vincent at vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)


More information about the gmp-bugs mailing list